Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-1119 Fixed to now have username and passwords passed in again #384

Merged
merged 1 commit into from
Nov 21, 2014

Conversation

cyberious
Copy link

No description provided.

@underscorgan
Copy link

@cyberious this has acceptance test failures, gathering more information now...

@underscorgan
Copy link

@cyberious

Failures:

1) apt_key source => http:// works
Failure/Error: apply_manifest(pp, :catch_failures => true)
  Beaker::Host::CommandFailure:
  Host 'ubuntu-server-12042-x64' exited with 4 running:
  env PATH="/usr/bin:/opt/puppet-git-repos/hiera/bin:${PATH}" RUBYLIB="/opt/puppet-git-repos/hiera/lib:/opt/puppet-git-repos/hiera-puppet/lib:${RUBYLIB}" puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.so6Ptk
  Last 10 lines of output were:
  Info: Loading facts
  Info: Loading facts
  Notice: Compiled catalog for ubuntu-server-12042-x64.delivery.puppetlabs.net in environment production in 0.02 seconds
  Info: Applying configuration version '1416272699'
  Error: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/pubkey.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.so6Ptk
  Error: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/pubkey.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.so6Ptk
  Wrapped exception:
  invalid access mode http://apt.puppetlabs.com/pubkey.gpg (URI::HTTP resource is read only.)
  Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/pubkey.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.so6Ptk
  Notice: Finished catalog run in 0.03 seconds
# ./spec/acceptance/apt_key_provider_spec.rb:286:in `block (4 levels) in <top (required)>'

  2) apt_key source => http:// fails with a 404
Failure/Error: expect(r.stderr).to match(/404 Not Found/)
  expected "\e[1;31mWarning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.59ZGEf\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.59ZGEf\nWrapped exception:\ninvalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.)\e[0m\n\e[1;31mError: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.59ZGEf\e[0m\n" to match /404 Not Found/
  Diff:
  @@ -1,2 +1,8 @@
  -/404 Not Found/
  +Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
  +   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')
  +Error: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.59ZGEf
  +Error: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.59ZGEf
  +Wrapped exception:
  +invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.)
  +Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabs.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.59ZGEf
# ./spec/acceptance/apt_key_provider_spec.rb:301:in `block (5 levels) in <top (required)>'
# ./spec/acceptance/apt_key_provider_spec.rb:300:in `block (4 levels) in <top (required)>'

  3) apt_key source => http:// fails with a socket error
Failure/Error: expect(r.stderr).to match(/could not resolve/)
  expected "\e[1;31mWarning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.cKKE2T\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.cKKE2T\nWrapped exception:\ninvalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.)\e[0m\n\e[1;31mError: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.cKKE2T\e[0m\n" to match /could not resolve/
  Diff:
  @@ -1,2 +1,8 @@
  -/could not resolve/
  +Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
  +   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')
  +Error: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.cKKE2T
  +Error: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.cKKE2T
  +Wrapped exception:
  +invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.)
  +Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode http://apt.puppetlabss.com/herpderp.gpg (URI::HTTP resource is read only.) at 5:/tmp/apply_manifest.pp.cKKE2T
# ./spec/acceptance/apt_key_provider_spec.rb:315:in `block (5 levels) in <top (required)>'
# ./spec/acceptance/apt_key_provider_spec.rb:314:in `block (4 levels) in <top (required)>'

  4) apt_key source => ftp:// works
Failure/Error: apply_manifest(pp, :catch_failures => true)
  Beaker::Host::CommandFailure:
  Host 'ubuntu-server-12042-x64' exited with 4 running:
  env PATH="/usr/bin:/opt/puppet-git-repos/hiera/bin:${PATH}" RUBYLIB="/opt/puppet-git-repos/hiera/lib:/opt/puppet-git-repos/hiera-puppet/lib:${RUBYLIB}" puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.3nTo6I
  Last 10 lines of output were:
  Info: Loading facts
  Info: Loading facts
  Notice: Compiled catalog for ubuntu-server-12042-x64.delivery.puppetlabs.net in environment production in 0.02 seconds
  Info: Applying configuration version '1416272701'
  Error: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/RPM-GPG-KEY-CentOS-6 (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.3nTo6I
  Error: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/RPM-GPG-KEY-CentOS-6 (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.3nTo6I
  Wrapped exception:
  invalid access mode ftp://ftp.cvut.cz/centos/RPM-GPG-KEY-CentOS-6 (URI::FTP resource is read only.)
  Error: /Stage[main]/Main/Apt_key[CentOS 6]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/RPM-GPG-KEY-CentOS-6 (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.3nTo6I
  Notice: Finished catalog run in 0.04 seconds
# ./spec/acceptance/apt_key_provider_spec.rb:335:in `block (4 levels) in <top (required)>'

  5) apt_key source => ftp:// fails with a 550
Failure/Error: expect(r.stderr).to match(/550 Failed to open/)
  expected "\e[1;31mWarning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.nGz2FB\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.nGz2FB\nWrapped exception:\ninvalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.)\e[0m\n\e[1;31mError: /Stage[main]/Main/Apt_key[CentOS 6]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.nGz2FB\e[0m\n" to match /550 Failed to open/
  Diff:
  @@ -1,2 +1,8 @@
  -/550 Failed to open/
  +Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
  +   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')
  +Error: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.nGz2FB
  +Error: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.nGz2FB
  +Wrapped exception:
  +invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.)
  +Error: /Stage[main]/Main/Apt_key[CentOS 6]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode ftp://ftp.cvut.cz/centos/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.nGz2FB
# ./spec/acceptance/apt_key_provider_spec.rb:350:in `block (5 levels) in <top (required)>'
# ./spec/acceptance/apt_key_provider_spec.rb:349:in `block (4 levels) in <top (required)>'

  6) apt_key source => ftp:// fails with a socket error
Failure/Error: expect(r.stderr).to match(/could not resolve/)
  expected "\e[1;31mWarning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.ktbFWp\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.ktbFWp\nWrapped exception:\ninvalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.)\e[0m\n\e[1;31mError: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.ktbFWp\e[0m\n" to match /could not resolve/
  Diff:
  @@ -1,2 +1,8 @@
  -/could not resolve/
  +Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
  +   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')
  +Error: Could not set 'present' on ensure: invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.ktbFWp
  +Error: Could not set 'present' on ensure: invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.ktbFWp
  +Wrapped exception:
  +invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.)
  +Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode ftp://apt.puppetlabss.com/herpderp.gpg (URI::FTP resource is read only.) at 5:/tmp/apply_manifest.pp.ktbFWp
# ./spec/acceptance/apt_key_provider_spec.rb:364:in `block (5 levels) in <top (required)>'
# ./spec/acceptance/apt_key_provider_spec.rb:363:in `block (4 levels) in <top (required)>'

  7) apt_key source => https:// works
Failure/Error: apply_manifest(pp, :catch_failures => true)
  Beaker::Host::CommandFailure:
  Host 'ubuntu-server-12042-x64' exited with 4 running:
  env PATH="/usr/bin:/opt/puppet-git-repos/hiera/bin:${PATH}" RUBYLIB="/opt/puppet-git-repos/hiera/lib:/opt/puppet-git-repos/hiera-puppet/lib:${RUBYLIB}" puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.aA1MGp
  Last 10 lines of output were:
  Info: Loading facts
  Info: Loading facts
  Notice: Compiled catalog for ubuntu-server-12042-x64.delivery.puppetlabs.net in environment production in 0.02 seconds
  Info: Applying configuration version '1416272703'
  Error: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/pubkey.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.aA1MGp
  Error: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/pubkey.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.aA1MGp
  Wrapped exception:
  invalid access mode https://apt.puppetlabs.com/pubkey.gpg (URI::HTTPS resource is read only.)
  Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/pubkey.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.aA1MGp
  Notice: Finished catalog run in 0.03 seconds
# ./spec/acceptance/apt_key_provider_spec.rb:379:in `block (4 levels) in <top (required)>'
  8) apt_key source => https:// fails with a 404
Failure/Error: expect(r.stderr).to match(/404 Not Found/)
  expected "\e[1;31mWarning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.ovcZp0\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.ovcZp0\nWrapped exception:\ninvalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.)\e[0m\n\e[1;31mError: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.ovcZp0\e[0m\n" to match /404 Not Found/
  Diff:
  @@ -1,2 +1,8 @@
  -/404 Not Found/
  +Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
  +   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')
  +Error: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.ovcZp0
  +Error: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.ovcZp0
  +Wrapped exception:
  +invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.)
  +Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabs.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.ovcZp0
# ./spec/acceptance/apt_key_provider_spec.rb:394:in `block (5 levels) in <top (required)>'
# ./spec/acceptance/apt_key_provider_spec.rb:393:in `block (4 levels) in <top (required)>'

  9) apt_key source => https:// fails with a socket error
Failure/Error: expect(r.stderr).to match(/could not resolve/)
  expected "\e[1;31mWarning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.cqioIt\e[0m\n\e[1;31mError: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.cqioIt\nWrapped exception:\ninvalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.)\e[0m\n\e[1;31mError: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.cqioIt\e[0m\n" to match /could not resolve/
  Diff:
  @@ -1,2 +1,8 @@
  -/could not resolve/
  +Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
  +   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')
  +Error: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.cqioIt
  +Error: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.cqioIt
  +Wrapped exception:
  +invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.)
  +Error: /Stage[main]/Main/Apt_key[puppetlabs]/ensure: change from absent to present failed: Could not set 'present' on ensure: invalid access mode https://apt.puppetlabss.com/herpderp.gpg (URI::HTTPS resource is read only.) at 5:/tmp/apply_manifest.pp.cqioIt
# ./spec/acceptance/apt_key_provider_spec.rb:408:in `block (5 levels) in <top (required)>'
# ./spec/acceptance/apt_key_provider_spec.rb:407:in `block (4 levels) in <top (required)>'

  Finished in 55.25 seconds
  36 examples, 9 failures

  Failed examples:

  rspec ./spec/acceptance/apt_key_provider_spec.rb:277 # apt_key source => http:// works
  rspec ./spec/acceptance/apt_key_provider_spec.rb:291 # apt_key source => http:// fails with a 404
  rspec ./spec/acceptance/apt_key_provider_spec.rb:305 # apt_key source => http:// fails with a socket error
  rspec ./spec/acceptance/apt_key_provider_spec.rb:326 # apt_key source => ftp:// works
  rspec ./spec/acceptance/apt_key_provider_spec.rb:340 # apt_key source => ftp:// fails with a 550
  rspec ./spec/acceptance/apt_key_provider_spec.rb:354 # apt_key source => ftp:// fails with a socket error
  rspec ./spec/acceptance/apt_key_provider_spec.rb:370 # apt_key source => https:// works
  rspec ./spec/acceptance/apt_key_provider_spec.rb:384 # apt_key source => https:// fails with a 404
  rspec ./spec/acceptance/apt_key_provider_spec.rb:398 # apt_key source => https:// fails with a socket error

@cyberious
Copy link
Author

@mhaskel resolved in PR, also found a bug, the apt_key absent will only delete the first key, not all keys.

@underscorgan
Copy link

@cyberious I think that issue is because your code is behind master by quite a bit, all tests are passing if I rebase this against master first.

underscorgan pushed a commit that referenced this pull request Nov 21, 2014
MODULES-1119 Fixed to now have username and passwords passed in again
@underscorgan underscorgan merged commit 1e7cef8 into puppetlabs:1.6.x Nov 21, 2014
@underscorgan
Copy link

Thanks @cyberious !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants