Stop redeclaring variables from params #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E_NOMERGE says Github :(. |
underscorgan
force-pushed
the
local_variable_declarations
branch
from
ae71c42
to
21d44ac
Compare
|
too many PRs touching too many things. try this. |
| @@ -65,8 +63,8 @@ | |||
| $file_name = regsubst($title, '[^0-9a-z\-_\.]', '_', 'IG') | |||
|
|
|||
| $path = $order ? { | |||
| '' => "${preferences_d}/${file_name}.pref", | |||
| default => "${preferences_d}/${order}-${file_name}.pref", | |||
| '' => "${apt::params::preferences_d}/${file_name}.pref", | |||
There was a problem hiding this comment.
Couldn't his just be apt::preferences_d? We require apt and it inherits from params.t
It really seems unnecessary.
underscorgan
force-pushed
the
local_variable_declarations
branch
from
21d44ac
to
7c5a62f
Compare
|
done. |
daenney
added a commit
that referenced
this pull request
Feb 21, 2015
Stop redeclaring variables from params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It really seems unnecessary.