apt::source: Rename trusted_source.
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is weird that `trusted_source` would default to `false` as that would imply that we normally don't trust our sources. This is opposite to the truth, by default we trust them but only if the Releases file can be verified (meaning it is signed by a GPG key known to apt). What we were telling apt is that it should trust this source even if the Releases file and the repository is unsigned. This is better captured with `allow_unsigned` and better highlights the danger of what you're doing, installing packages from a source we cannot authenticate.
underscorgan
pushed a commit
that referenced
this pull request
Mar 6, 2015
apt::source: Rename `trusted_source`.
|
Thanks @daenney ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is weird that
trusted_sourcewould default tofalseas that wouldimply that we normally don't trust our sources. This is opposite to the
truth, by default we trust them but only if the Releases file can be
verified (meaning it is signed by a GPG key known to apt).
What we were telling apt is that it should trust this source even if the
Releases file and the repository is unsigned. This is better captured
with
allow_unsignedand better highlights the danger of what you'redoing, installing packages from a source we cannot authenticate.