Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt::source: Make location required. #453

Merged
merged 1 commit into from Mar 6, 2015
Merged

Conversation

daenney
Copy link

@daenney daenney commented Mar 5, 2015

In what universe does it make sense to create a sources.list.d entry for a repository without specifying where this repository is? 馃槚

馃槥 馃槱 馃槯 馃槺

Only when removing the resource should a location not be required.

@daenney daenney force-pushed the daenney/location-required branch 3 times, most recently from 572960c to f014048 Compare March 5, 2015 19:50
@underscorgan underscorgan added this to the 2.0 milestone Mar 6, 2015
@underscorgan
Copy link

@daenney sorrrry I made this need a rebase :(

In what universe does it make sense to create a `sources.list.d` entry
for a repository **without** specifying where this repository is?
:confounded:

:disappointed: :weary: :anguished: :scream:

Only when removing the resource should a location not be required.
@daenney
Copy link
Author

daenney commented Mar 6, 2015

Done!

underscorgan pushed a commit that referenced this pull request Mar 6, 2015
@underscorgan underscorgan merged commit 481846b into next Mar 6, 2015
@underscorgan
Copy link

Thanks @daenney !

@daenney daenney deleted the daenney/location-required branch March 7, 2015 16:45
@LukasAud LukasAud added the bugfix label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants