Added new apt_reboot_required fact, updated readme, and added unit tests #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dlactin, sorry for the inconveniencce, but this will need a rebase since the README update was just merged. Let me know if you need any help with that! |
dlactin
force-pushed
the
feature/master/apt_reboot_required_fact
branch
from
f956880
to
6e51be7
Compare
|
I think I am all set, let me know if you need me to to something else. |
| @@ -443,4 +445,4 @@ Puppet Labs modules on the Puppet Forge are open projects, and community contrib | |||
|
|
|||
| For more information, see our [module contribution guide.](https://docs.puppetlabs.com/forge/contributing.html) | |||
|
|
|||
| To see who's already involved, see the [list of contributors.](https://github.com/puppetlabs/puppetlabs-apt/graphs/contributors) | |||
There was a problem hiding this comment.
This line shouldn't have been removed
|
@dlactin looks like one line was accidentally removed from the README in the rebase, but once you add that back in we're good to go! thanks! |
|
I forgot to turn off eol before I finished my changes. Should be good to go! |
underscorgan
pushed a commit
that referenced
this pull request
Apr 29, 2015
…ed_fact Added new apt_reboot_required fact, updated readme, and added unit tests
|
👍 thanks @dlactin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fact to determine if a reboot is necessary after updates have been installed, along with unit tests and comment in the README.