Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of $::apt::params::backports and $::apt::params::xfacts. #542

Merged
merged 1 commit into from Jun 22, 2015

Conversation

Farzy
Copy link

@Farzy Farzy commented Jun 22, 2015

This commit fixes the usage of 2 default parameters which were misnamed $::apt::backports and $apt::xfacts and adds missing "inherits apt::params" or "include apt::params".

jonnytdevops added a commit that referenced this pull request Jun 22, 2015
Fix use of $::apt::params::backports and $::apt::params::xfacts.
@jonnytdevops jonnytdevops merged commit 8f5cb73 into puppetlabs:master Jun 22, 2015
@daenney
Copy link

daenney commented Jun 22, 2015

This goes against everything we've designed this module for. You have to have apt included in your manifests so there is no need to use include apt::params or inherit apt::params anywhere else. These values are directly accessible under the apt:: namespace which is what this code was doing and the tests proved it was working.

@mhaskel HALP 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants