add safe handling of IPv6 address for APT proxy #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSecure
commented
Dec 8, 2016
MrSecure
commented
- update required version of stdlib to get additional validation routines
- verify that proxy['host'] is a valid IPv4, IPv6, or domain name
- enclose IPv6 addresses in [ ] as needed
- move validate_hash() block in order to keep all of the proxy config stuff together
- ensure port number is a valid integer ( < 65536)
- add test for IPv6 address behavior
* update required version of stdlib to get additional validation routines * verify that proxy['host'] is a valid IPv4, IPv6, or domain name * enclose IPv6 addresses in [ ] as needed * move validate_hash() block in order to keep all of the proxy config stuff together * ensure port number is a valid integer ( < 65536)
|
Hi @MrSecure , thanks for the work you have put into this pull request. However due to inactivity and failing unit tests / needing rebased, this pull request is being closed. If you want to re-submit this PR with the necessary changes, we will gladly look at the new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.