Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-4973) rip out data in modules #680

Merged
merged 1 commit into from
May 25, 2017
Merged

Conversation

eputnam
Copy link

@eputnam eputnam commented May 25, 2017

this module is not able to find a value for $keyserver when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.

@eputnam eputnam force-pushed the remove_dim branch 2 times, most recently from dcc68df to 030520d Compare May 25, 2017 20:25
this module is not able to find a value for `$keyserver` when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.
@hunner hunner merged commit 33d17cf into puppetlabs:master May 25, 2017
hunner added a commit that referenced this pull request May 25, 2017
this module is not able to find a value for `$keyserver` when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.
SergK added a commit to SergK/puppetlabs-rabbitmq that referenced this pull request May 29, 2017
Latest changes in puppetlabs-apt master branch [1] breaks current CI.
This change fixes CI by pinning puppetlabs-apt to tag: 4.0.0

[1]. puppetlabs/puppetlabs-apt#680
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Apr 9, 2024
params.pp and create_resources() are obsolete.

This module was converted to non-params.pp style puppetlabs#667, but was
reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the
preferred styles these days.
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Apr 9, 2024
params.pp and create_resources() are obsolete.

This module was converted to non-params.pp style puppetlabs#667, but was
reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the
preferred styles these days.
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Apr 9, 2024
params.pp and create_resources() are obsolete.

This module was converted to non-params.pp style puppetlabs#667, but was
reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the
preferred styles these days.
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Apr 9, 2024
params.pp and create_resources() are obsolete.

This module was converted to non-params.pp style puppetlabs#667, but was
reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the
preferred styles these days.
jamesps-ebi added a commit to jps-help/puppetlabs-apt that referenced this pull request Aug 1, 2024
eliminate params.pp and create_resources()

params.pp and create_resources() are obsolete.

This module was converted to non-params.pp style puppetlabs#667, but was
reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the
preferred styles these days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants