-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a facter fact for dist-upgrade #719
Conversation
a1ba556
to
7219ed2
Compare
|
i took a peek at tests. may have something to do with scoping in RSpec. while i was testing apt_dist_has_updates_spec.rb, the fact was returning |
7219ed2
to
09a3ff9
Compare
|
@eputnam I can't replicate this, if I add the expect outside of the block then it returns nil, the opposite of what you are seeing. Travis has gone green too. Let's discuss this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a Facts section in the readme, would you mind updating that?
This commit adds a facter fact for dist-upgrade, along with associated facter facts.
09a3ff9
to
ab5c977
Compare
|
Facts in readme updated, thanks |
|
Thanks @eputnam |
This commit adds a facter fact for dist-upgrade, along with
associated facter facts.
(Builds upon PR #634 - adds a new set of facts to maintain compatibility)