(MODULES-8418) Fix /etc/apt/auth.conf owner changing endlessly #836
Conversation
|
@antaflos Thanks for taking this on and adding tests. Everything looks good to me. Would it be possible for you to modify your main commit message to use a ticket number i.e. "(MODULES-1234) - Fix /etc/apt/auth.conf..." ? You can find more info on the CONTRIBUTING page. Cheers! |
|
@eimlav will do, but I can't find a suitable ticket to reference at https://tickets.puppetlabs.com/browse/MODULES-7583?jql=text%20~%20puppetlabs-apt%20ORDER%20BY%20updated%20DESC I'll have to create one first. |
|
@antaflos Yep just create a ticket, amend your commit message and that should do it! |
antaflos
changed the title
Starting from Debian 9 and Ubuntu 16.04 the user _apt owns the file /etc/apt/auth.conf. In previous versions it is owned by root. Set ownership of /etc/apt/auth.conf correctly based on OS version and add spec tests to cover managing the file's owner under Ubuntu 14.04, 16.04 and 18.04 as well as Debian 7.0, 8.0 and 9.0.
antaflos
force-pushed
the
fix_auth_conf_owner
branch
from
a2d378f
to
627eb0b
Compare
|
I have created https://tickets.puppetlabs.com/browse/MODULES-8418 and squashed the two commits into one, amending the commit message with the MODULES-8418 reference. |
|
LGTM. Thanks for the contribution! :) |
This PR takes the great work of @voegelas in #829, rebases it on current master and extends the spec tests for managing /etc/apt/auth.conf to cover setting the file's owner under different operating systems (Debian 7/8/9 and Ubuntu 14.04/16.04/18.04).