Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apt::key_options for default apt::key options #873

Merged
merged 3 commits into from Aug 14, 2019
Merged

Add apt::key_options for default apt::key options #873

merged 3 commits into from Aug 14, 2019

Conversation

raphink
Copy link

@raphink raphink commented Aug 8, 2019

This allows to set global default for apt::key options (such as http proxies), just as it is done with keyserver.

Copy link

@ThoughtCrhyme ThoughtCrhyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphink thanks for the PR! Could you add spec tests for key_options in the same way that we already test keyserver? https://github.com/puppetlabs/puppetlabs-apt/blob/master/spec/unit/puppet/type/apt_key_spec.rb#L20

If we can check that the default setting is undef and test that whatever setting you pass to it properly maintained we can get this merged. Thank you

@raphink
Copy link
Author

raphink commented Aug 14, 2019

Thanks for the comment @ThoughtCrhyme . I'm not touching the type though, only the defined resource type, where keyserver defaults is not tested currently. So I'll add tests for both keyserver and key_options.

@raphink
Copy link
Author

raphink commented Aug 14, 2019

Looks like the acceptance tests timed out.

@ThoughtCrhyme ThoughtCrhyme merged commit d871d7f into puppetlabs:master Aug 14, 2019
@raphink raphink deleted the default_key_options branch August 15, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants