Fix task-output-json to work as documented

[seanmil]

Currently the task_output_keys/values are always printed with double quotes around the value, preventing task-output-json from working as intended.

Additionally, this includes a refactoring of the unit test as the current one is flawed and does not test anything meaningful.

[seanmil]

Note, if the system running the unit tests does not have an iconv that supports the --unicode-subst option then this requires #20 to be merged first in order for all the tests to succeed properly.

[m0dular]

There's an issue with the tests where the repo is cloned with the puppetlabs- prefix, so it's trying to source the script from

$PT__installdir/bash_task_helper

when it lives at $PT__installdir/puppetlabs-bash_task_helper in CI. I know that r10k will install the module without the puppetlabs- prefix so this seems like a CI problem, but I'm not sure what to change in order to fix this.

[seanmil]

There's an issue with the tests where the repo is cloned with the puppetlabs- prefix, so it's trying to source the script from

$PT__installdir/bash_task_helper

when it lives at $PT__installdir/puppetlabs-bash_task_helper in CI. I know that r10k will install the module without the puppetlabs- prefix so this seems like a CI problem, but I'm not sure what to change in order to fix this.

I rebased my original commit and then modified the tests to avoid needing to know the name of the directory it was cloned as. I couldn't see a drawback to this approach and tests are passing now.

[m0dular]

This should be fixed in #23 as well. Does your approach of source "$PT__installdir/files/task_helper.sh" work when actually running a task with Bolt that uses the helper? If so, then either approach would probably be ok.

[seanmil]

This should be fixed in #23 as well. Does your approach of source "$PT__installdir/files/task_helper.sh" work when actually running a task with Bolt that uses the helper? If so, then either approach would probably be ok.

No, with my approach the "examples/mytask.sh" task would not work when run via Bolt. Let's go with your fix in #23 ! I've dropped my path change and repushed just the original change/fix.

[m0dular]

I think we just need a rebase from main for this branch and it's good to go. The tests passed for me locally after doing so.

[m0dular]

👍