-
Notifications
You must be signed in to change notification settings - Fork 68
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-chocolatey
base: 3.2.0
head repository: puppetlabs/puppetlabs-chocolatey
compare: 3.3.0
- 12 commits
- 16 files changed
- 5 contributors
Commits on Feb 20, 2019
-
Merge pull request #145 from puppetlabs/release
Mergeback from 3.2.0
Configuration menu - View commit details
-
Copy full SHA for 5a48606 - Browse repository at this point
Copy the full SHA 5a48606View commit details
Commits on Feb 22, 2019
-
(MODULES-8047) Fix puppet resource chocolateyconfig
Prior to this commit running `puppet resource chocolateyconfig` would fail during the validation block which verified that no config items were both :present *and* had an empty :value or were missing :value altogether. This is because Chocolatey represents a configuration item which is using the defaults as an empty string. When collecting instances of Chocolatey config items from the configuration file, it would find the items, mark them as :present, and save them with a :value of "". This would then fail the validation block. During a `puppet apply` run the validation block is called before the instances are fetched - and, therefore, before `@property_hash` is populated. This allows us to distinguish between the two calls and error on any declared resources which specify `:ensure` as `:present` but forget to specify a `:value`. This commit moves the validation logic from the type into the provider in order to allow us to take advantage of the @property_hash information during a `puppet resource` run. This commit also updates the `get_config` method to treat any discovered Chocolatey config item with an empty value as `:absent` - this matches the behavior of `:ensure => :absent` which calls `choco config unset` - this command replaces the existing value of a config item with an empty string. Now when returning the list of Chocolatey configs our model of them is consistent, with `:absent` meaning that the configuration item is set to the default. This commit does not change the behavior of a `puppet apply` run. This commit *does* include changes to the unit tests to reflect the moving of the validation logic.
Configuration menu - View commit details
-
Copy full SHA for 6f5e090 - Browse repository at this point
Copy the full SHA 6f5e090View commit details
Commits on Feb 25, 2019
-
Merge pull request #146 from michaeltlombardi/ticket/master/MODULES-8…
…047-fix-chococonfig (MODULES-8047) Fix puppet resource chocolateyconfig
Erick Banks authoredFeb 25, 2019 Configuration menu - View commit details
-
Copy full SHA for 80ee252 - Browse repository at this point
Copy the full SHA 80ee252View commit details
Commits on Feb 27, 2019
-
(MODULES-8491) Warn about
install_optionssecretsThis commit adds a warning note to the package parameter documentation on `install_options`, clarifying that it is _possible_ that secrets will leak during a debug run and **likely** that they will leak to the Chocolatey log on the machine in any case. The warning further advises users who need to use a secret in their `install_options` to do the following: 1. Never run in debug mode with production credentials. 2. Acquire a C4B license and use the `--package-parameters-sensitive` flag to redact the values from the Chocolatey log.
Configuration menu - View commit details
-
Copy full SHA for 88d890c - Browse repository at this point
Copy the full SHA 88d890cView commit details -
Merge pull request #147 from michaeltlombardi/ticket/masterMODULES-8491
(MODULES-8491) Warn about `install_options` secrets
Configuration menu - View commit details
-
Copy full SHA for c875d20 - Browse repository at this point
Copy the full SHA c875d20View commit details
Commits on Mar 11, 2019
-
(MODULES-6652) Make 7zip DL source configurable
Prior to this commit the 7zip executable, a requirement for the installation of Chocolatey, was hardcoded for download from a single internet URL. This caused failures when pointed through a proxy. This commit adds a new parameter, `$seven_zip_download_url` to the Chocolatey class. This is used to specify the path to the `7za.exe` binary, which can live anywhere that the Puppet File resource can retrieve it for the target machine. It uses such a file declaration in the `install.pp` manifest to handle cases where the use of 7zip is required. This parameter defaults to the previously hardcoded URL, `https://chocolatey.org/7za.exe`. This commit also adds a new fact, `choco_temp_dir`, to discover the appropriate temporary folder on disk in which to place the 7zip binary. It follows the pattern for using/testing facts as the `choco_install_path` fact already used in this module, by adding the logic for the fact in helper code. This commit therefore also includes new tests to the module for the helper code, the fact, the parameter, and the expected change in behavior. It also includes updated documentation per the new parameter.
Configuration menu - View commit details
-
Copy full SHA for f50315d - Browse repository at this point
Copy the full SHA f50315dView commit details -
Merge pull request #94 from helge000/MODULES-6652
(MODULES-6652) Fix download 7z behind proxy
Erick Banks authoredMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for e743906 - Browse repository at this point
Copy the full SHA e743906View commit details
Commits on Mar 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9914263 - Browse repository at this point
Copy the full SHA 9914263View commit details -
Merge pull request #148 from michaeltlombardi/release
(MODULES-8739) 3.3.0 Release Prep
Configuration menu - View commit details
-
Copy full SHA for 4533a17 - Browse repository at this point
Copy the full SHA 4533a17View commit details
Commits on Mar 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8f38759 - Browse repository at this point
Copy the full SHA 8f38759View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43a3249 - Browse repository at this point
Copy the full SHA 43a3249View commit details -
Merge pull request #150 from puppetlabs/clairecadman-patch-2
(MODULES-8739) DOCS Release Review
Configuration menu - View commit details
-
Copy full SHA for cc0b540 - Browse repository at this point
Copy the full SHA cc0b540View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 3.2.0...3.3.0