(MODULES-3037) Manage sources #1

ferventcoder · 2016-03-15T19:18:56Z

Provide the ability manage a source with a custom type and provider.
This allows a source to be ensurable, and also allows for a source to
be manageable in the same converge that Chocolatey is installed
during. This further allows for installing packages from custom
sources all in the same Puppet run.

Add .vscode.

Add testing information to the examples manifest.

ferventcoder · 2016-05-13T20:52:06Z

spec/unit/puppet_x/chocolatey/chocolatey_common_spec.rb

+describe 'Chocolatey Common' do
+
+  context 'on Windows', :if => Puppet::Util::Platform.windows? do
+


This is empty right now, but I wanted to get eyes on this so we can get it merged and through soon. So we can pick this up in other tickets or as maint.

ferventcoder · 2016-05-13T21:05:41Z

@puppetlabs/windows please review.

glennsarti · 2016-05-16T22:54:01Z

lib/puppet_x/chocolatey/chocolatey_common.rb

+        if Puppet::Util::Platform.windows?
+          chocoInstallPath = PuppetX::Chocolatey::ChocolateyInstall.install_path
+          #default_location = $::choco_installpath || ENV['ALLUSERSPROFILE'] + '\chocolatey'
+          chocopath = ('C:\ProgramData\chocolatey' if file_exists?('C:\ProgramData\chocolatey\bin\choco.exe')) ||


I'm not 100% comfortable with using a hardcoded path for C:\ProgramData. It tends to be surfaced as %ALLUSERSPROFILE% or at least %SYSTEMDRIVE%\ProgramData

This section is a straight copy from the package provider. There be voodo and reasons there, they haven't been all determined yet.

glennsarti · 2016-05-16T23:10:39Z

Is it worth refactoring out the "magic" version numbers in the unit tests e.g. 0.9.9.10 etc?

ferventcoder · 2016-05-17T15:17:09Z

Is it worth refactoring out the "magic" version numbers in the unit tests e.g. 0.9.9.10 etc?

Yeah, I think we should make it clearer - I'll change it to minimum_supported_version - that should make it pretty clear what is being tested.

glennsarti · 2016-05-17T17:59:44Z

spec/unit/puppet_x/chocolatey/chocolatey_install_spec.rb

+
+  context 'on Linux', :if => Puppet.features.posix? do
+    it "should return the default install path on a non-windows system" do
+      PuppetX::Chocolatey::ChocolateyInstall.install_path.must == 'C:\ProgramData\chocolatey'


This seems counter-intuitive. On a linux system wouldn't the install path be nil or empty?

Default path when one is not found.

ferventcoder · 2016-05-18T00:01:52Z

@puppetlabs/windows paired with @glennsarti some today on this as we fought through refactoring the Chocolatey package provider bits to get them to use PuppetX::Chocolatey::ChocolateyCommon. Lots of tests needed touched and adjusted.

There may be an underlying issue or two with when choco.exe is actually found (every system that runs these tests has Chocolatey installed). We removed it for a bit to ensure things would work without it.

ferventcoder · 2016-05-18T00:03:33Z

~~I'll pick these up tomorrow and work to get them overridden.~~ All ready to go

- Move chocolatey_spec to spec/unit/puppet/provider/package - Add tests around `PuppetX::ChocolateyInstall`. - Lean out tests for `choco_install_path` Fact since it calls `PuppetX::ChocolateyInstall `.

Move the bits for the fact `chocolateyversion` to `PuppetX::Chocolatey::ChocolateyVersion`. Move the tests around and update appropriately as well. Also when working against 0.9.8.33, handle the warning message that is shown to users before the version message.

If a registry check does not turn up results, ChocolateyInstall should fall back to looking at process/user environment variable to determine if the environment variable `ChocolateyInstall` is defined.

When working with Chocolatey, there are common calls that are necessary to complete operations using choco. Create that as a PuppetX module to be used by providers.

The package provider for Chocolatey should use the ChocolateyCommon methods instead of maintaining its own version of those methods. Refactor it to use those instead.

Provide the ability manage a source with a custom type and provider. This allows a source to be ensurable, and also allows for a source to be manageable in the same converge that Chocolatey is installed during. This further allows for installing packages from custom sources all in the same Puppet run.

ferventcoder · 2016-05-20T20:17:12Z

@puppetlabs/windows all comments have been addressed. Ready to go.

glennsarti · 2016-05-20T21:43:38Z

Looks good to me.

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch 2 times, most recently from bf02558 to c00496f Compare March 16, 2016 23:08

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch from c00496f to 9b0f33f Compare April 21, 2016 23:24

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch 3 times, most recently from d4ef65d to 00a0d0e Compare May 6, 2016 23:39

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch 9 times, most recently from dd56022 to 1a83680 Compare May 13, 2016 20:25

ferventcoder added 3 commits May 13, 2016 15:31

(maint) update git ignore

e147c8c

Add .vscode.

(maint) update example manifest w/testing info

e688158

Add testing information to the examples manifest.

(maint) formatting

fef13ab

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch from 1a83680 to 3ca0c2e Compare May 13, 2016 20:49

ferventcoder reviewed May 13, 2016
View reviewed changes

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch from 3ca0c2e to a9f159a Compare May 13, 2016 20:58

ferventcoder changed the title ~~(MODULES-3037) WIP~~ (MODULES-3037) Manage sources May 13, 2016

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch 2 times, most recently from 10e5f8f to 187c92c Compare May 13, 2016 22:22

glennsarti reviewed May 16, 2016
View reviewed changes

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch from 187c92c to 8a97145 Compare May 17, 2016 17:31

glennsarti reviewed May 17, 2016
View reviewed changes

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch 3 times, most recently from 382550d to 1ff4c3e Compare May 17, 2016 23:57

(maint) clean up tests

bc482df

- Move chocolatey_spec to spec/unit/puppet/provider/package - Add tests around `PuppetX::ChocolateyInstall`. - Lean out tests for `choco_install_path` Fact since it calls `PuppetX::ChocolateyInstall `.

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch from 1ff4c3e to 28bd939 Compare May 18, 2016 18:52

ferventcoder mentioned this pull request May 18, 2016

(MODULES-3035) Manage configuration settings #17

Merged

5 tasks

ferventcoder added 5 commits May 20, 2016 14:50

(maint) ChocolateyInstall should check environment

1376d3d

If a registry check does not turn up results, ChocolateyInstall should fall back to looking at process/user environment variable to determine if the environment variable `ChocolateyInstall` is defined.

(MODULES-3037) Add common calls

6b4eb9b

When working with Chocolatey, there are common calls that are necessary to complete operations using choco. Create that as a PuppetX module to be used by providers.

(maint) Refactor Chocolatey provider to use Common

2d80372

The package provider for Chocolatey should use the ChocolateyCommon methods instead of maintaining its own version of those methods. Refactor it to use those instead.

ferventcoder force-pushed the ticket/master/MODULES-3037-source branch from 28bd939 to 086cb40 Compare May 20, 2016 19:52

glennsarti merged commit e08b0dd into puppetlabs:master May 20, 2016

ferventcoder deleted the ticket/master/MODULES-3037-source branch May 20, 2016 21:47

ferventcoder mentioned this pull request Jun 6, 2016

{WIP}(PUP-3428) Configure Chocolatey chocolatey-archive/puppet-chocolatey#79

Closed

LukasAud added the feature label May 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(MODULES-3037) Manage sources #1

(MODULES-3037) Manage sources #1

ferventcoder commented Mar 15, 2016 •

edited

Loading

ferventcoder May 13, 2016

ferventcoder commented May 13, 2016

glennsarti May 16, 2016

ferventcoder May 17, 2016

glennsarti commented May 16, 2016

ferventcoder commented May 17, 2016

glennsarti May 17, 2016

ferventcoder May 17, 2016

ferventcoder commented May 18, 2016

ferventcoder commented May 18, 2016 •

edited

Loading

ferventcoder commented May 20, 2016

glennsarti commented May 20, 2016

		describe 'Chocolatey Common' do

		context 'on Windows', :if => Puppet::Util::Platform.windows? do

(MODULES-3037) Manage sources #1

(MODULES-3037) Manage sources #1

Conversation

ferventcoder commented Mar 15, 2016 • edited Loading

ferventcoder May 13, 2016

Choose a reason for hiding this comment

ferventcoder commented May 13, 2016

glennsarti May 16, 2016

Choose a reason for hiding this comment

ferventcoder May 17, 2016

Choose a reason for hiding this comment

glennsarti commented May 16, 2016

ferventcoder commented May 17, 2016

glennsarti May 17, 2016

Choose a reason for hiding this comment

ferventcoder May 17, 2016

Choose a reason for hiding this comment

ferventcoder commented May 18, 2016

ferventcoder commented May 18, 2016 • edited Loading

ferventcoder commented May 20, 2016

glennsarti commented May 20, 2016

ferventcoder commented Mar 15, 2016 •

edited

Loading

ferventcoder commented May 18, 2016 •

edited

Loading