Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/master/modules 3138 #12

Merged
merged 9 commits into from
Apr 16, 2016

Conversation

ThoughtCrhyme
Copy link

Removed r-spec tests and fixed beaker acceptance test.

--debug \
--preserve-hosts never \
--config tests/configs/$PLATFORM \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if $PLATFORM is not set?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure the task will fail with a descriptive message if the $PLATFORM envar is not set.

@cowofevil cowofevil self-assigned this Apr 12, 2016
The linter was not liking the hash rocket alignment on the examples
file.
@cowofevil
Copy link

@ThoughtCrhyme See PR to fix Travis CI failure.

task :reference_tests => [:blah]

task :blah do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a more descriptive name and maybe a comment on how it is triggered.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! Meant to change that before push

The reference tests pre-suite was using the "agents" host array when
calling the "install_dev_puppet_module_on". However, a method used within
the "install_dev_puppet_module_on" did not support an array of hosts.
The fix is to feed "install_dev_puppet_module_on" a single host object in a
block.
@cowofevil cowofevil merged commit 5e8866c into puppetlabs:master Apr 16, 2016
ThoughtCrhyme pushed a commit to ThoughtCrhyme/puppetlabs-chocolatey that referenced this pull request Mar 20, 2017
…kens-everywhere

(QA-2030) Use auth tokens everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants