(MODULES-5897) Add allow_self_service to chocolateysource #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Jan 29, 2019
| @@ -189,6 +197,10 @@ def flush | |||
| args << '--bypass-proxy' if resource[:bypass_proxy].to_s == 'true' | |||
| end | |||
|
|
|||
| if choco_gem_version >= Gem::Version.new(MINIMUM_SUPPORTED_CHOCO_VERSION_ALLOW_SELF_SERVICE) | |||
| args << '--allow-self-service' if resource[:allow_self_service].to_s == 'true' | |||
There was a problem hiding this comment.
Can use args << '--allow-self-service' if resource[:allow_self_service] == :true here
Prior to this commit the `chocolateysource` type and provider did not support the option to specify the `--allow-self-service` flag when managing a source. This option causes Chocolatey to mark the source as being usable with the C4B Self-Service feature as of C4B v1.10.0. It requires Chocolatey 0.10.4+ to set this option. This commit adds the `allow_self_service` property to the type and provider of `chocolateysource` to ensure that this property can be configured on versions which support it. This commit also updates the README documentation and CHANGELOG, as well as providing new unit and acceptance tests and updating any unit and acceptance tests which should include the new setting.
glennsarti
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the
chocolateysourcetype and provider didnot support the option to specify the
--allow-self-serviceflagwhen managing a source. This option causes Chocolatey to mark the
source as being usable with the C4B Self-Service feature as of
C4B v1.10.0. It requires Chocolatey 0.10.4+ to set this option.
This commit adds the
allow_self_serviceproperty to the type andprovider of
chocolateysourceto ensure that this propertycan be configured on versions which support it.
This commit also updates the README documentation and CHANGELOG,
as well as providing new unit and acceptance tests and updating
any unit and acceptance tests which should include the new
setting.