(MODULES-9690) Redact Sensitive Commandline #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change redacts the commandline used with the `chocolateysource` type if the user supplies a password. If the user does not set a password for the source then no redaction takes place. If a password is supplied then the entire commandline that contains the password will be redacted. This change also allows the user to specify a value to the `password` parameter using the `Sensitive` data type, but note that this is not required. The commandline will be redacted even if a normal string is provided, and using the `Sensitive` type will cause Puppet to raise a warning, even though nothing is wrong.
RandomNoun7
force-pushed
the
MODULES-9690-password-redaction
branch
from
0bf224a
to
c3b92d8
Compare
michaeltlombardi
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change redacts the commandline used with the
chocolateysourcetype if the user supplies a password.
If the user does not set a password for the source then no redaction
takes place. If a password is supplied then the entire commandline that
contains the password will be redacted.
This change also allows the user to specify a value to the
passwordparameter using the
Sensitivedata type, but note that this is notrequired. The commandline will be redacted even if a normal string is
provided, and using the
Sensitivetype will cause Puppet to raisea warning, even though nothing is wrong.