(MODULES-3035) Manage configuration settings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
2 times, most recently
from
c8b0fcb
to
6dfb7a3
Compare
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
from
6dfb7a3
to
1941336
Compare
| # may not be a bad idea entirely, as choco would just put back the default values automatically | ||
| # that way. | ||
| if @property_flush[:ensure] == :absent && choco_version < Gem::Version.new(CONFIG_MINIMUM_SUPPORTED_CHOCO_VERSION_UNSET) | ||
| #todo use xml writing instead |
There was a problem hiding this comment.
One of the things left to do.
|
@puppetlabs/windows this is ready to start reviewing. |
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
from
ae05bc7
to
661fc36
Compare
| if (self[:title] =~ /password/i) | ||
| # If name contains password, it is | ||
| # always in sync if there is a value | ||
| return (is.nil? || is.empty?) == (should.nil? || should.empty?) |
There was a problem hiding this comment.
Not really sure how to test this in specs. I have a pretty good idea of testing it in reference tests though.
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
4 times, most recently
from
22f3d71
to
163d9a2
Compare
Provide the ability to manage config settings with a custom type and provider. This allows a config setting to be ensurable, and also allows for a config settings to be manageable in the same converge that Chocolatey is installed. The minimum version of Chocolatey has been set at 0.9.10 as that is where unsetting configuration values was implemented. When it comes to config values that contain passwords, those are not ensurable, but the insync? will check to see if it has a value or not and respond appropriately.
For acceptance/reference tests, ensure that Chocolatey is installed from choco-pipeline-tests instead of temp-build-tools.
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
from
163d9a2
to
c90f3fd
Compare
ferventcoder
changed the title
|
Assuming adhoc build is ok, 👍 for merge |
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
from
c90f3fd
to
410e5c5
Compare
Add reference/acceptance tests for chocolateyconfig. These test the following: - adding a new config item - adding a value to an empty existing config item - changing a config value - seeing how changing a config value with password does not change the value unless going from empty to a value - removing a value from a config setting - removing a value from a config setting named with password - attempt to apply a bad manifest - attempt to set ensure=>present with no value
ferventcoder
force-pushed
the
ticket/master/MODULES-3035-config
branch
from
410e5c5
to
7631c06
Compare
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
…refactor_client (QA-2035) Refactor Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1 to be merged first.Provide the ability to manage config settings with a custom type and
provider. This allows a config setting to be ensurable, and also
allows for a config settings to be manageable in the same converge
that Chocolatey is installed during.
Things to accomplish: