Use datatypes and facts hash. Remove logic for Puppet 3.x #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting the PR @treydock .Could you please update the branch. Thank you. |
treydock
force-pushed
the
datatypes-facts
branch
from
0eb62b0
to
9c66246
Compare
|
@sheenaajay I've updated tests to pass |
treydock
force-pushed
the
datatypes-facts
branch
from
9c66246
to
7dd52b0
Compare
|
@treydock Could you please rebase with the latest master. Thank you. |
treydock
force-pushed
the
datatypes-facts
branch
from
7dd52b0
to
4e1fc9d
Compare
|
Rebased |
carabasdaniel
approved these changes
Oct 2, 2019
|
Hello @treydock, thank you for your contribution, this looks good |
glennsarti
reviewed
Oct 2, 2019
| @@ -152,15 +152,15 @@ | |||
| end | |||
| end | |||
|
|
|||
| ['string', false, ''].each do |param_value| | |||
| ['string', false, '', '1', '30'].each do |param_value| | |||
glennsarti
reviewed
Oct 2, 2019
| @@ -53,7 +53,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| invalid_url_values = ['\\\\ciflocation\\share', 'bob', '4', ''] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.