(MODULES-3037) Acceptance tests - ChocolateySource #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `get_xml_value` to take config file output and verify configuration values from it. - Added `backup_config`/`reset_config` to copy a backup of the config file and reset it when a test is complete.
|
@ThoughtCrhyme here you go sir |
ferventcoder
force-pushed
the
ticket/master/MODULES-3037-acceptance
branch
from
3ca1680
to
9271e68
Compare
ferventcoder
changed the title
|
@puppetlabs/windows this set of specs is ready to be reviewed. Mostly happy path items. @ThoughtCrhyme is working on the negative tests. Please review and pull in. I've ran the tests and they all pass locally for me. Test Suite: tests @ 2016-05-31 15:43:25 -0500
- Host Configuration Summary -
- Test Case Summary for suite 'tests' -
Total Suite Time: 277.74 seconds
Average Test Time: 21.36 seconds
Attempted: 13
Passed: 13
Failed: 0
Errored: 0
Skipped: 0
Pending: 0
Total: 13 |
| on(agent, "cmd.exe /c \"type #{config_file_location}\"") do |result| | ||
| assert_not_match(/tim/, get_xml_value("//sources/source[@id='chocolatey']/@user", result.output).to_s, 'User was not removed') | ||
| #todo looking for assert_empty value | ||
| assert_not_match(/test/, get_xml_value("//sources/source[@id='chocolatey']/@password", result.output).to_s, 'Password was not removed') |
There was a problem hiding this comment.
This could probably be changed to /.+/
Acceptance tests that verify chocolateysource provider for Windows. - Verifies adding, changing and removing priority - Verifies adding, changing and removing user/password - verifies adding source with minimal options happy path - verifies adding source with all options happy path
ferventcoder
force-pushed
the
ticket/master/MODULES-3037-acceptance
branch
from
9271e68
to
44ab890
Compare
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
…bug_fix_for_ttl_extension (QA-2197) Bug Fix for Lifetime Extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.