(MODULES-3034) Feature Configuration #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support enabling or disabling chocolatey features
Add examples and reference for Chocolatey Feature.
|
The spec tests should pass, the reference tests should fail - I was having issues with flipping nokogiri so I was not able to get that finished. Ugh. |
| step 'Apply manifest' | ||
| apply_manifest(chocolatey_src, :expect_failures => true) do | ||
| step 'Verify Failure' | ||
| assert_match(/Error: Validation of Chocolateyfeature\[checksumFiles\] failed: asdf/, stderr, "stderr did not match expected") |
There was a problem hiding this comment.
WIP - this is on purpose to cause an error - Want to find out what the value is to add but was not able to get tests running locally.
Add the reference tests for Chocolatey Feature.
ferventcoder
force-pushed
the
ticket/master/MODULES-3034-conifguration-feature
branch
from
e97cabd
to
bdc93da
Compare
ferventcoder
changed the title
|
@puppetlabs/windows this is ready for final review and merge. |
ferventcoder
deleted the
ticket/master/MODULES-3034-conifguration-feature
branch
|
YTMND! |
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
(maint) update presentations README and puppet reveal.js template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #23.
Support enabling or disabling chocolatey features.
Add documentation and reference tests.