(MODULES-10638) Ease mocking of chocolatey internals

[DavidS]

By using values from facter for choco_install_path and chocolateyversion
instead of directly calling into the utility code, users of this module
who want to run unit tests on non-windows platforms can provide mocked
fact values and avoid running into issues with the utility functions trying
to read the registry.

[DavidS]

I'll need to test whether this works on the first run to install choco AND manage packages in the same run.

[rnelson0]

While this isn't passing tests, I can confirm these changes DO allow compile tests of classes that include chocolatey to pass! My changes to the reproduction case:

# In the spec test, uncomment the compile test:
      it { is_expected.to compile }

# In .fixtures.yml, replace the forge module for chocolatey with:
  repositories:
    chocolatey:
      repo: "https://github.com/DavidS/puppetlabs-chocolatey"
      ref: "6619259"

# Add back some hieradata fixtures at spec/fixtures/hieradata/environment.yaml
# Software Versions
ahchocolatey::version: '0.10.15'
ahchocolatey::versionext: '2.0.2'
ahchocolatey::source: "%{lookup('artifactory_nuget_url')}"
chocolatey::choco_install_location: 'c:\local_folder'

[michaeltlombardi]

Well this is a small, clever, maintainable solution! 🎉