(MODULES-3490) Sync from Community Repo #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerShell v2/3 caches the output stream. Then it throws errors due to the FileStream not being what is expected. Fixes "The OS handle's position is not what FileStream expected. Do not use a handle simultaneously in one FileStream and in Win32 code or another FileStream." The fix comes from http://www.leeholmes.com/blog/2008/07/30/workaround-the-os-handles-position-is-not-what-filestream-expected/ plus information in the comments that actually makes it work.
The Chocolatey install PowerShell script has been signed at dot org and all of the scripts in Chocolatey 0.9.10 are being signed, so it is appropriate to sign this script as well for the benefit of folks who would need that.
The output from error messages is way too much when these are on by default. It would be helpful to see only what has errored and allow the user to investigate further if need be. This gives the user the ability to choose whether or not to add those values to the arguments as part of `install_options` and `uninstall_options`.
To increase awareness that Professional and Business editions are available, add information in the readme.
There is a syntax error in the readme related to setting the default provider for Windows. It needs a second set of brackets surrounding Package.
If the PowerShell Output redirection fix does not successfully apply, we don't want it to fail the entire script. It uses internal variables that only apply to the PowerShell InternalHost/ConsoleHost that short-circuited logging and caused a FileStream error when you attempted to write to multiple log streams. Due to sometimes calling this script with non-default PowerShell hosts (like with the new 2.0 puppet powershell provider), we want to ensure that if the fix errors, it does not fail the entire script.
Update config.pp to accomodate new choco feature list -r output. The findstr fails to match on the new version of chocolatey 0.9.10.2. It can now find: "autoUninstaller|Enabled|" or "autoUninstaller|Disabled|"
* pr132: (chocolatey-archiveGH-133) Feature list update for 0.9.10
Removed a line break which was causing installation issues with 1.x versions of the PowerShell provider module. Older versions of PowerShell, such as PowerShell v2, and the 1.x module do not handle line breaks with else statements very well.
* pr129: (chocolatey-archiveGH-128) PowerShell 1.x provider fixes for "else"
| $_find_str = "autoUninstaller|${_enable_autouninstaller}d|" | ||
| } else { | ||
| $_find_str = "autoUninstaller - [${_enable_autouninstaller}d]" | ||
| } |
There was a problem hiding this comment.
This actually still has an issue to be resolved.
There was a problem hiding this comment.
It is. I think I have this fixed up though so I will commit and update this.
In 0.9.10, auto uninstaller should be enabled by default, so there is no need to run to enable it.
To allow for specs to run correctly on older versions of Ruby, json requires using less than 2.0.0. Interestingly though, json should not be used for regular testing as it requires devkit. Remove both gems that depend on json so that tests in older versions of Windows will work and so that testing doesn't require DevKit.
Module updated with lastest modsync settings # Conflicts: # .gitignore # Gemfile
…ster/chocolatey-archiveGH-134-autouninstaller (chocolatey-archiveGH-134) Only Enable AutoUninstaller in 0.9.9.x
* master: (version) 1.2.6 (MODULES-3536) modsync update (maint) Remove travis and metadata-json-lint gems (chocolatey-archiveGH-134) Only Enable AutoUninstaller in 0.9.9.x (version) 1.2.5 (maint) prep for release of 1.2.5 (chocolatey-archiveGH-128) PowerShell 1.x provider fixes for "else" (chocolatey-archiveGH-133) Feature list update for 0.9.10 (version) 1.2.4 (chocolatey-archiveGH-125) Compatible Up to PowerShell Provider 3.x (chocolatey-archiveGH-125) Wrap PowerShell Redirect in Try/Catch (chocolatey-archiveGH-69) Fix - default provider example (doc) make that text a bit more prominent (version) 1.2.3 for real (version) 1.2.3 (doc) add editions of Chocolatey (chocolatey-archiveGH-100) Do not call choco with --debug --verbose (version) 1.2.2 Sign the installer script template (chocolatey-archiveGH-119) Implement PowerShell Redirection Fix
ferventcoder
force-pushed
the
ticket/master/MODULES-3490-sync
branch
from
46a71f5
to
845d93c
Compare
|
Passed ad hoc - @glennsarti all ready for your final +1 and merge. |
| * Fix: puppet apply works again - see [#105](https://github.com/chocolatey/puppet-chocolatey/issues/105) | ||
| * Includes community module releases up to 1.2.1, plus these additional fixes: | ||
| * $::chocolateyversion fact is optional - see [#110](https://github.com/chocolatey/puppet-chocolatey/issues/110) | ||
| * Fix: puppet apply works again - see [#105](https://github.com/chocolatey/puppet-chocolatey/issues/105) |
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
…x_empty_record_crash (QA-2681) Fix Empty Record Crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.