(GH-283) Fix deprecation error #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
GH-283-choco_update_is_deprecated
branch
2 times, most recently
from
4083d49
to
1ce86e9
Compare
In situations where the resource described in the manifest includes a version in its ensure property and choco v1 or above is installed, puppet runs would fail. This was happening of an issue where the version of chocolatey was not being properly derived by choco_version. In turn, would cause compiled_choco to return false causing the module to default to using choco update rather than choco upgrade. This commit fixes that by ensuring that the choco_version method returns the correct puppet version.
chelnak
force-pushed
the
GH-283-choco_update_is_deprecated
branch
from
74d4cd9
to
1a83f70
Compare
david22swan
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #283
In situations where the resource described in the manifest includes a version in its
ensureproperty andchocov1 or above is installed, puppet runs would fail. This was happening of an issue where the version of chocolatey was not being properly derived bychoco_version.In turn, would cause
compiled_chocoto return false causing the module to default to usingchoco updaterather thanchoco upgrade.What has changed?
This PR fixes that by ensuring that the
choco_versionmethod returns the correct puppet version.We can now observe the correct behaviour, even when the
chocolateyversionfact has not been populated.