Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-3275) fix VLC uninstall command #30

Merged

Conversation

ThoughtCrhyme
Copy link

Added "retry_on" to vlc uninstall command.
Removed check for vlc.exe actually being removed thus placing a high amount of faith in the proper execution of the "retry_on" command. This is risk that we're taking, but it has a low probability of interfering with other tests so long as we don't reuse the vlc package in other tests.

@ferventcoder
Copy link

can you update the commit message? "(MODULES-3275) fix VLC uninstall command"

@ThoughtCrhyme ThoughtCrhyme changed the title MODULES-3275 fix up vlc uninstall command (MODULES-3275) fix VLC uninstall command Jul 8, 2016
@ferventcoder
Copy link

LGTM. I've kicked off adhoc

@ferventcoder ferventcoder merged commit 6a145a1 into puppetlabs:master Jul 10, 2016
ThoughtCrhyme pushed a commit to ThoughtCrhyme/puppetlabs-chocolatey that referenced this pull request Mar 20, 2017
…6/add_randell_prototype

(QA-2736) Add Randell Pelak Prototype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants