(MODULES-3880) Ignore Package Exit Codes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Chocolatey v0.9.10, choco started allowing uninstall with a source agument again. This is necessary for alternative sources - otherwise choco doesn't know how to remove "packages" from those sources and instead looks for packages by that name.
When working with 0.9.10 or greater, pass the switch to ignore exit codes. When a user is also passing the same switch, Chocolatey will ignore the duplication.
ferventcoder
force-pushed
the
exitcodes
branch
from
01a8da1
to
fb842a1
Compare
ferventcoder
changed the title
|
This passed adhoc testing. |
jpogran
reviewed
Sep 21, 2016
| if @resource[:source] | ||
| args << '-source' << @resource[:source] | ||
| end | ||
|
|
||
| args << @resource[:install_options] | ||
|
|
||
| if Gem::Version.new(PuppetX::Chocolatey::ChocolateyCommon.choco_version) >= Gem::Version.new(PuppetX::Chocolatey::ChocolateyCommon::MINIMUM_SUPPORTED_CHOCO_VERSION_EXIT_CODES) |
There was a problem hiding this comment.
Nit: can these be made variables? Super long line makes its hard to read the important part
jpogran
reviewed
Sep 21, 2016
| if @resource[:source] | ||
| args << '-source' << @resource[:source] | ||
| end | ||
| end | ||
|
|
||
| args << @resource[:uninstall_options] | ||
|
|
||
| if Gem::Version.new(PuppetX::Chocolatey::ChocolateyCommon.choco_version) >= Gem::Version.new(PuppetX::Chocolatey::ChocolateyCommon::MINIMUM_SUPPORTED_CHOCO_VERSION_EXIT_CODES) |
There was a problem hiding this comment.
Same here. Super long line and readability
|
👍 Can ignore my nit comments if you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might need a ticket @jpogran / @puppetlabs/windows
A few maintenance fixes that I've been wanting to do prior to the release, the bigger of which is to add the ignore package exit codes.