(MODULES-4091) Explicitly Set ChocolateyInstall Environment #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking at determining the version of Chocolatey for configuration purposes in config.pp, determine if the value of `$chocolatey::chocolatey_version` is coming back undefined. If it is, return a string with 0 as the value. Add a local variable to make that determination and use it instead of the fact in the versioncmp checks.
ferventcoder
commented
Nov 23, 2016
| # lint:ignore:80chars | ||
| if versioncmp($chocolatey::chocolatey_version, '0.9.9.0') >= 0 and versioncmp($chocolatey::chocolatey_version, '0.9.10.0') < 0 { | ||
| if versioncmp($_choco_version, '0.9.9.0') >= 0 and versioncmp($_choco_version, '0.9.10.0') < 0 { |
There was a problem hiding this comment.
Tiny annoyance fixed as an additional maint commit.
ferventcoder
commented
Nov 23, 2016
| exec { 'install_chocolatey_official': | ||
| command => template('chocolatey/InstallChocolatey.ps1.erb'), | ||
| creates => "${::chocolatey::choco_install_location}\\bin\\choco.exe", | ||
| provider => powershell, | ||
| timeout => $::chocolatey::choco_install_timeout_seconds, | ||
| logoutput => $::chocolatey::log_output, | ||
| environment => ["ChocolateyInstall=${::chocolatey::choco_install_location}"] | ||
| environment => ["ChocolateyInstall=${::chocolatey::choco_install_location}"], |
There was a problem hiding this comment.
We are not removing this in hopes that it will still get fixed.
ferventcoder
commented
Nov 23, 2016
| ensure => present, | ||
| path => 'HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Environment\ChocolateyInstall', | ||
| type => 'string', | ||
| data => $chocolatey::choco_install_location, |
There was a problem hiding this comment.
Not sure if this needs quoted in case it has spaces.
Previously, ensuring the installation directory for Chocolatey keyed off of an environment value passed to an exec powershell resource through the environment parameter. However there is a bug in the powershell module in versions 2.x up to 2.1.0 (current version as of this commit) that ignore the environment parameter. Since it is better to explicitly set that value, take a dependency on the registry module and explicitly ensure the environment variable is set so that Chocolatey will successfully install to an alternative install location.
ferventcoder
force-pushed
the
ticket/master/MODULES-4091-alternate_directory
branch
from
8d2f40f
to
c760fb6
Compare
ferventcoder
deleted the
ticket/master/MODULES-4091-alternate_directory
branch
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
Added in meta data for numerous QA modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ensuring the installation directory for Chocolatey
keyed off of an environment value passed to an exec powershell
resource through the environment parameter. However there is a
bug in the powershell module in versions 2.x up to 2.1.0
(current version as of this commit) that ignore the environment
parameter. Since it is better to explicitly set that value, take
a dependency on the registry module and explicitly ensure the
environment variable is set so that Chocolatey will successfully
install to an alternative install location.