(MODULES-4056) Helpful Error if No Sources Enabled #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
reviewed
Dec 14, 2016
| @@ -473,6 +473,14 @@ | |||
| :name => 'package2' | |||
| } | |||
| end | |||
|
|
|||
| it "should return nil on error" do | |||
| provider.expects(:execpipe).yields(StringIO.new(%Q(Unable to search for packages when there are not soures enabled for packages and none were passed as arguments.\n))) | |||
There was a problem hiding this comment.
Nitpick: no sources instead of not sources
There was a problem hiding this comment.
Ah yes. Typo adding command. Will fix.
Previously, when there were no sources enabled, Puppet would attempt to loop over a non-existent set of packages pulled back from listing a set of packages locally. Unfortunately this is due to an issue in Chocolatey that requires at least one source to be enabled to produce the local set of installed packages: chocolatey/choco#661 Instead of allowing Puppet to fail on a nil:NilClass error, provide a helpful and actionable message instead.
ferventcoder
force-pushed
the
ticket/master/MODULES-4056-no_sources_error
branch
from
29cdf02
to
3647114
Compare
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
Adding Sierra nodeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when there were no sources enabled, Puppet would
attempt to loop over a non-existent set of packages pulled back
from listing a set of packages locally. Unfortunately this is due
to an issue in Chocolatey that requires at least one source to be
enabled to produce the local set of installed packages:
chocolatey/choco#661
Instead of allowing Puppet to fail on a nil:NilClass error, provide
a helpful and actionable message instead.