(MODULES-4678) Explicitly close config on read #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any providers managing Chocolatey configuration are unable to be used with 0.10.4+ and actually cause the process to fail. Chocolatey 0.10.4+ has changed the way it updates and accesses the config. The new method has exposed an error in an unclosed file handle when reading the configuration for `chocolateysource`, `chocolateyfeature`, and `chocolateyconfig`. Switch to `File.read` as it will automatically close the file after reading out the contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any providers managing Chocolatey configuration are unable
to be used with 0.10.4+ and actually cause the process to
fail.
Chocolatey 0.10.4+ has changed the way it updates and accesses the
config. The new method has exposed an error in an unclosed file handle
when reading the configuration for
chocolateysource,chocolateyfeature, andchocolateyconfig. Switch toFile.readasit will automatically close the file after reading out the contents.