Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add choco_ver variable and string it #88

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Conversation

tek0011
Copy link

@tek0011 tek0011 commented Oct 23, 2017

Added a choco_ver variable and then string it (to_s) it to avoid the rendering error.

@jpogran
Copy link

jpogran commented Oct 23, 2017

Hi @tek0011 thanks for the fix. Could you fixup your commit message to include the ticket number in the header and flesh out the commit message a bit more to include why the change was made? Like: (MODULES-5788) Fix Choco version string

We can merge this pretty quickly after that

Added a choco_ver variable and then string it (to_s) it to avoid the rendering error. Using puppet facts --render-as (yaml||json) would cause:
!ruby/string:Puppet::Util::Execution::ProcessOutput <version>
@jpogran jpogran merged commit 53293cc into puppetlabs:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants