Permalink
Browse files

Fixes various puppet-lint warnings.

* ./manifests/init.pp - WARNING: ensure found on line but it's not the first attribute on line 222
* ./manifests/setup.pp - WARNING: selector inside resource block on line 34
* ./manifests/fragment.pp - WARNING: case statement without a default case on line 28
  • Loading branch information...
1 parent 7490f60 commit 370e60280d74ada1e2ed130034e34bb7955bc929 @vStone vStone committed Aug 30, 2012
Showing with 9 additions and 5 deletions.
  1. +3 −0 manifests/fragment.pp
  2. +1 −1 manifests/init.pp
  3. +5 −4 manifests/setup.pp
View
@@ -29,6 +29,9 @@
'', 'absent', 'present', 'file', 'directory': {
crit('No content, source or symlink specified')
}
+ default: {
+ #do nothing, make puppet-lint happy.
+ }
}
}
default: { File{ source => $source } }
View
@@ -218,8 +218,8 @@
}
file { $name:
- path => $path,
ensure => present,
+ path => $path,
alias => "concat_${name}",
group => $group,
mode => $mode,
View
@@ -26,15 +26,16 @@
}
$majorversion = regsubst($::puppetversion, '^[0-9]+[.]([0-9]+)[.][0-9]+$', '\1')
+ $fragments_source = $majorversion ? {
+ 24 => 'puppet:///concat/concatfragments.sh',
+ default => 'puppet:///modules/concat/concatfragments.sh'
+ }
file{"${concatdir}/bin/concatfragments.sh":
owner => $id,
group => $root_group,
mode => '0755',
- source => $majorversion ? {
- 24 => 'puppet:///concat/concatfragments.sh',
- default => 'puppet:///modules/concat/concatfragments.sh'
- };
+ source => $fragments_source;
[ $concatdir, "${concatdir}/bin" ]:
ensure => directory,

0 comments on commit 370e602

Please sign in to comment.