Fix aix/windows ownership issues and vardir path #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it { should be_owned_by username } | ||
| it { should be_grouped_into groupname } | ||
| it("should be mode 644", :unless => fact('osfamily') == "AIX") { | ||
| should be_mode 644 |
There was a problem hiding this comment.
specinfra doesn't have a be_mode matcher on AIX. I'll have to write one, but disabling this test so it will go green in our jenkins.
There was a problem hiding this comment.
Nor be_linked_to (well, it tries to run stat but should be istat).
There was a problem hiding this comment.
Also the useradd/groupadd obviously won't work on AIX or windows :)
There was a problem hiding this comment.
Aww, I didn't know about the limitation on AIX. A #xxx comment at least in the file might same some head scratching. Otherwise, this looks good.
Phil0xF7
added a commit
that referenced
this pull request
Feb 26, 2014
Fix aix/windows ownership issues and vardir path
| it { should be_owned_by 'root' } | ||
| it { should be_grouped_into 'root' } | ||
| it { should be_mode 644 } | ||
| it { should contain '2' } |
There was a problem hiding this comment.
I'm half asleep but did we just lose the contain lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.