Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix numeric sorting #174

Merged
merged 1 commit into from
May 1, 2014
Merged

Conversation

bdeak
Copy link

@bdeak bdeak commented Apr 25, 2014

Reworked change to be in a separate branch as requested. This is a fix for numeric sorting supporting spaces in the fragment file names.

@igalic
Copy link
Contributor

igalic commented Apr 28, 2014

Looking good, +1

apenney pushed a commit that referenced this pull request May 1, 2014
@apenney apenney merged commit 6a3bdd0 into puppetlabs:master May 1, 2014
@janorn
Copy link

janorn commented May 28, 2014

Solaris 11 is "modern" and supports this feature.

@janorn
Copy link

janorn commented May 28, 2014

Can we use the ruby script instead?

@jhoblitt
Copy link
Contributor

The ruby script is only currently used on windows. We've been hesitant
to start using it on POSIX like systems due to all the subtle issues the
shell script has had to deal with. I suppose we could enable it just
for Solaris. Have you rb script on Solaris?

@bdeak
Copy link
Author

bdeak commented May 28, 2014

Can we get rid of spaces in the fragment names? Print0 is only needed to
wirk around the spaces-in-filenames problem.
On May 28, 2014 5:58 PM, "Joshua Hoblitt" notifications@github.com wrote:

The ruby script is only currently used on windows. We've been hesitant
to start using it on POSIX like systems due to all the subtle issues the
shell script has had to deal with. I suppose we could enable it just
for Solaris. Have you rb script on Solaris?


Reply to this email directly or view it on GitHubhttps://github.com//pull/174#issuecomment-44427222
.

@janorn
Copy link

janorn commented May 28, 2014

As puppet depends on ruby we have ruby installed. Normally ruby is not available in Solaris 10.

I tried the ruby script from the command line. Seems to work.

jhoblitt pushed a commit to jhoblitt/puppetlabs-concat that referenced this pull request May 28, 2014
Per discussion on puppetlabs#174, Solaris 10 does not support the find/xargs
switches that were introduced in that PR (but Solaris 11 does).
@jhoblitt
Copy link
Contributor

@janorn Could you try PR #186 and see if it works for you on Solaris 10?

jhoblitt pushed a commit to jhoblitt/puppetlabs-concat that referenced this pull request May 28, 2014
Per discussion on puppetlabs#174, Solaris 10 does not support the find/xargs
switches that were introduced in that PR (but Solaris 11 does).
jhoblitt pushed a commit to jhoblitt/puppetlabs-concat that referenced this pull request May 28, 2014
Per discussion on puppetlabs#174, Solaris 10 does not support the find/xargs
switches that were introduced in that PR (but Solaris 11 does).

+ fix linter warnings/errors
jhoblitt pushed a commit to jhoblitt/puppetlabs-concat that referenced this pull request May 28, 2014
Per discussion on puppetlabs#174, Solaris 10 does not support the find/xargs
switches that were introduced in that PR (but Solaris 11 does).

+ add a shebang to concatfragments.rb
+ fix linter warnings/errors
jhoblitt pushed a commit to jhoblitt/puppetlabs-concat that referenced this pull request May 29, 2014
Per discussion on puppetlabs#174, Solaris 10 does not support the find/xargs
switches that were introduced in that PR (but Solaris 11 does).

+ add a shebang to concatfragments.rb
+ fix linter warnings/errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants