Validate the concat::fragment order parameter as string||integer #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
May 27, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
|
I haven't had the time to run down the ruby 1.8.7 test failure... This PR should be in a mergable state soon. |
|
The 10,000 cuts of ruby 1.8.7 continues... it appears that this module can no longer be tested for ruby 1.8.7 on fedora 20 due to gem deps having trouble with the bundled version of gcc. See: knu/ruby-unf_ext#8 |
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
May 28, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
added 3 commits
May 29, 2014 13:07
This is to work around a validation issue that arises under the 3.x future parser, as proper numeric types have been introduced (ie, not all scalar values are strings). Users have come to expect to to be able to pass in unquoted integer values to the order parameter which will fail to validate as a string when the future parser is enabled.
It appears that puppet 2.7.3 does not play nicely with stdlib 4.2.0.
|
This PR was rebased on master, no other changes were made. |
jhoblitt
pushed a commit
that referenced
this pull request
May 29, 2014
Validate the concat::fragment order parameter as string||integer
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 4, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 4, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 4, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 4, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 4, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 12, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
janorn
added a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 12, 2014
… for the order parameter. This might change with this pull request puppetlabs/puppetlabs-concat#185. Until then puppet-lint will complain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work around a validation issue that arises under the 3.x future
parser, as proper numeric types have been introduced (ie, not all scalar values
are strings). Users have come to expect to to be able to pass in unquoted
integer values to the order parameter which will fail to validate as a string
when the future parser is enabled.