Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the eq() checks as this breaks in PE3.3. #188

Merged
merged 1 commit into from Jun 2, 2014
Merged

Remove all the eq() checks as this breaks in PE3.3. #188

merged 1 commit into from Jun 2, 2014

Conversation

apenney
Copy link

@apenney apenney commented Jun 2, 2014

No description provided.

underscorgan pushed a commit that referenced this pull request Jun 2, 2014
Remove all the eq() checks as this breaks in PE3.3.
@underscorgan underscorgan merged commit 3465fe7 into puppetlabs:1.0.x Jun 2, 2014
@jhoblitt
Copy link
Contributor

jhoblitt commented Jun 2, 2014

I'm guessing this is hiera.yml or the package type virtual support warning? I've run into this myself and it's problematic. I wonder if we need a special matcher for stderr that ignores warn messages?

@apenney
Copy link
Author

apenney commented Jun 2, 2014

it's actually one of the other warnings from 3.6, it's been kind of a pain. I'm told they are rethinking the approach because right now it's a total mess. They shouldn't be sending warnings to stdERR! :)

@jhoblitt
Copy link
Contributor

jhoblitt commented Jun 2, 2014

I think sending warnings to the stderr is reasonable for puppet apply... that makes it easy to capture the regular program output without is being polluted with error messages.

My point is that if puppet is going to be producing warnings out of the box (hiera.yml/etc.) than we need some way of acceptance testing that differentiates between warnings and serious errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants