fix: permitting $backup to be boolean false

[flypenguin]

concat::backup can actually be a boolean false, which currently is not permitted by the validation, and should be. now it is :)

[jhoblitt]

The unit tests need to be updated and I suspect the acceptance tests as well.

[flypenguin]

updated the tests I found.

[jhoblitt]

@flypenguin Thank you for updating the tests. Question - is there any reason not to allow backup to accept a true boolean value?

[flypenguin]

because according to the File[] docs from puppetlabs (or as I understand
them :) the value for backup=> is either bool(false) or a string. I have no
clue what bool(true) might mean, so I made sure the value throws an error.

2014-08-13 16:12 GMT+02:00 Joshua Hoblitt notifications@github.com:

@flypenguin https://github.com/flypenguin Thank you for updating the
tests. Question - is there any reason not to allow backup to accept a true
boolean value?

—
Reply to this email directly or view it on GitHub
#208 (comment)
.

[jhoblitt]

According to the type refernce, true is an alias for " .puppet-bak". https://docs.puppetlabs.com/references/latest/type.html#file-attribute-backup

How about someting along the lines of:

if !(is_string($backup) or is_bool($backup)) {
  fail('$backup is not a string or bool.')
}

?

[flypenguin]

oops must have missed that. sure that's the better way then. I can do it tomorrow if you like.—
Sent from Mailbox

On Wed, Aug 13, 2014 at 4:54 PM, Joshua Hoblitt notifications@github.com
wrote:

According to the type refernce, true is an alias for " .puppet-bak". https://docs.puppetlabs.com/references/latest/type.html#file-attribute-backup
How about someting along the lines of:

if !(is_string($backup) or is_bool($backup)) {
  fail('$backup is not a string or bool.')
}

?

Reply to this email directly or view it on GitHub:
#208 (comment)

[flypenguin]

sorry, took a while longer. both string and boolean values are permitted now.

[jhoblitt]

Looks good. Thank you for contributing!

[flypenguin]

my pleasure :)