Fix validate_cmd file resource parameter #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validate_cmd parameter is only valid on newer versions of puppet. This module is supporting all 3.x versions of puppet. This commit only applies the validate_cmd parameter to the file resource if it is defined and adds documentation noting that it will not work on older versons of puppet.
|
👍 fixes the issue for me. |
jonnytdevops
added a commit
that referenced
this pull request
Feb 12, 2015
Fix validate_cmd file resource parameter
| File[$name] { | ||
| validate_cmd => $validate_cmd, | ||
| } | ||
| } |
There was a problem hiding this comment.
unless i'm entirely mistaken: given that validate_cmd's default is undef, we shouldn't really need the if here.
There was a problem hiding this comment.
If the validate_cmd parameter is unconditionally added to the file {} resource above then pre-3.5 versions will throw an error, irrespective of whether it's undef or set.
There was a problem hiding this comment.
ack. i did see the patch by @petems a bit too late before commenting here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validate_cmd parameter is only valid on newer versions of puppet.
This module is supporting all 3.x versions of puppet. This commit only
applies the validate_cmd parameter to the file resource if it is
defined and adds documentation noting that it will not work on older
versons of puppet.