Fixup $order parameter verification #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattern matching is only exercised on strings. Integers don't like that.
underscorgan
pushed a commit
that referenced
this pull request
Mar 2, 2015
Fixup $order parameter verification
|
Good catch, thanks @buzzdeee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the order parameter on sanity, make sure that
pattern matching is only exercised on strings. Integers
don't like that.
Without the patch, and integer passed, you end up with below error and aborted catalog like this:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Left match operand must result in a String value. Got an Integer. at /etc/puppet/environments/production/modules/concat/manifests/fragment.pp:45:11 on node XXX
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run