(MODULES-1700) Change the filebucketing behavior so static_compiler can ... #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,7 +141,7 @@ | |||
| } | |||
|
|
|||
| File { | |||
| backup => false, | |||
| backup => $backup, | |||
There was a problem hiding this comment.
I don't think this is needed to work with the static compiler. None of these files have sources pointing at the puppet fileserver.
There was a problem hiding this comment.
I tried reverting just this line and it looks like concat::setup inherited it:
Error: /Stage[main]/Concat::Setup/File[/var/lib/puppet/concat/bin/concatfragments.rb]/ensure: change from absent to file failed: Could not retrieve content for {md5}b684db0eac243553a6a79365119a363d from filebucket
|
I merged some things and now it needs a rebase, also. |
|
I'll handle the rebase and update |
|
I rebased then did a |
hunner
added a commit
that referenced
this pull request
Apr 7, 2015
…_for_static_compiler (MODULES-1700) Change the filebucketing behavior so static_compiler can ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...handle them