readd ensure_newline param and tests for backwards compatibility #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
added a commit
that referenced
this pull request
May 1, 2015
readd ensure_newline param and tests for backwards compatibility
| @@ -134,6 +140,11 @@ def fragment_content(r) | |||
| tmp = Puppet::FileServing::Content.indirection.find(@source, :environment => catalog.environment) | |||
| fragment_content = tmp.content unless tmp.nil? | |||
| end | |||
|
|
|||
| if self[:ensure_newline] | |||
| fragment_content<<"\n" | |||
There was a problem hiding this comment.
I think we should be checking to see if it has a newline before appending a newline. If it already ends in \n we will end up making a double newline.
There was a problem hiding this comment.
Something like
fragment_content << "\n" unless fragment_content =~ /\n$/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.