Allow using a custom name and provide a path to the file that needs to be created using concat. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, cn you please update the comments to capture the meaning of the argument and I will merge it |
|
Dunno how I could have forgotten that being a doc-nazi myself. |
ripienaar
added a commit
that referenced
this pull request
Aug 30, 2012
Allow using a custom name and provide a path to the file that needs to be created using concat.
|
thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we want to make the target file dynamic but still be able to add fragments in a generic way. This allows that.
Use case?
We create filenames based on the order files need to be created in (think apache vhosts ordering). Modules still need to be able to use a generic name to add fragments to this file without duplicating the logic in resolving the file path.