MODULES-2054 - fixes dependency bug in creating the target file #317
Conversation
| @@ -149,7 +149,6 @@ | |||
| end | |||
| describe file("#{basedir}/fail_no_source") do | |||
| #FIXME: Serverspec::Type::File doesn't support exists? for some reason. so... hack. | |||
| it { should_not be_file } | |||
There was a problem hiding this comment.
why is this being removed? Shouldn't things that are not files still not be files?
There was a problem hiding this comment.
Had a convo with @hunner about this. Since we've moved the resource creation to generate and updating of the content to eval_generate, if we fail to fetch the content from the fragments and the file doesn't exist, the apply will create an empty file. If the file does exist, it will be left unmodified. This is different from previous behavior but I think this is an edge case and the impact that this change could cause doesn't outweigh the complexity we'd have to add to the eval_generate function in order to properly handle cleaning up the resource in the catalog on rescue. ¯_(ツ)_/¯
bmjen
changed the title
bmjen
changed the title
underscorgan
changed the title
bmjen
force-pushed
the
tableflip
branch
2 times, most recently
from
6502ab9
to
53cdf25
Compare
bmjen
changed the title
| } | ||
|
|
||
| concat::fragment { 'foo': | ||
| target => '#{basedir}/bar/foobar', |
There was a problem hiding this comment.
I think this needs to be target => 'foobar'
MODULES-2054 - fixes dependency bug in creating the target file
No description provided.