fix fragment target handling #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Check if either source or content is set. raise error if none is set | ||
| fail Puppet::ParseError, "Set either 'source' or 'content'" if self[:source].nil? && self[:content].nil? | ||
|
|
||
| # Check if both are set, if so rais error | ||
| fail Puppet::ParseError, "Can't use 'source' and 'content' at the same time" if !self[:source].nil? && !self[:content].nil? | ||
|
|
||
| self[:tag] = regsubst(self[:target], '[/:\n\s]', '_', 'GM') if self[:tag].nil? |
There was a problem hiding this comment.
doesn't this change the required-ness of tag? or at least change the default? May be a feature, should have docs, should maybe be split out.
There was a problem hiding this comment.
You're right. forgot to remove that bit. Need to add a check in the validation block too.
Needed to bind fragment targets to it's parent concat resource's title so that we can find them in the catalog. Throws a warning if the target is not found.
underscorgan
pushed a commit
that referenced
this pull request
May 28, 2015
fix fragment target handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to bind fragment targets to it's parent concat resource's title so that we can
find them in the catalog. Throws a warning if the target is not found.