adds file autorequire #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autorequire will add parent directories of the concat_file to the dependency chain. So they can be created in the right order if they do not exist.
|
👍 |
|
Thanks for this. You can close MODULES-2023 as appropriate (I'd raised this issue there). |
mkarpiarz
pushed a commit
to datacentred/puppet
that referenced
this pull request
Sep 20, 2016
This commit updates the nginx submodule to the voxpupuli repo (https://github.com/jfryman/puppet-nginx.git is just a reference to the voxpupuli repo, so nothing should change here) and checks out to a commit before the one that reverted the hostfix from voxpupuli/puppet-nginx#624 This fixes the problem with nginx trying to create a vhost configuration before installing the nginx package. This is caused by concat not requiring the underlying nginx file hierarchy. This solution needs to be reverted when concat devs come up with a working implementation of the autorequire function in `lib/puppet/type/concat_file.rb`. The current solution from ba643617a2a03f0588a0ec6625824a707528d9f0 (L112-L115) is not working and the original approach: puppetlabs/puppetlabs-concat#319 has been abandoned at some point. For more details see the ticket: https://datacentred.atlassian.net/browse/PD-2567.
spjmurray
pushed a commit
to datacentred/puppet
that referenced
this pull request
Sep 20, 2016
This commit updates the nginx submodule to the voxpupuli repo (https://github.com/jfryman/puppet-nginx.git is just a reference to the voxpupuli repo, so nothing should change here) and checks out to a commit before the one that reverted the hostfix from voxpupuli/puppet-nginx#624 This fixes the problem with nginx trying to create a vhost configuration before installing the nginx package. This is caused by concat not requiring the underlying nginx file hierarchy. This solution needs to be reverted when concat devs come up with a working implementation of the autorequire function in `lib/puppet/type/concat_file.rb`. The current solution from ba643617a2a03f0588a0ec6625824a707528d9f0 (L112-L115) is not working and the original approach: puppetlabs/puppetlabs-concat#319 has been abandoned at some point. For more details see the ticket: https://datacentred.atlassian.net/browse/PD-2567.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autorequire will add parent directories of the concat_file to the dependency chain.
So they can be created in the right order if they do not exist.