(MODULES-2080) Call out changed behaviour of 'warn' parameter #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 2.0.0, this parameter would add a newline at the end of the warn message. To improve flexibilty, this was removed. Please add it explicitely if you need it.
tphoney
added a commit
that referenced
this pull request
May 29, 2015
(MODULES-2080) Call out changed behaviour of 'warn' parameter
| @@ -183,9 +183,13 @@ Specifies whether to add a header message at the top of the destination file. Va | |||
| If you set 'warn' to 'true', `concat` adds the following message: | |||
|
|
|||
| ~~~ | |||
| # This file is managed by Puppet. DO NOT EDIT. | |||
| # This file is managed by Puppet. DO NOT EDIT.\n | |||
There was a problem hiding this comment.
not really sure how useful the \n here is in the README…
There was a problem hiding this comment.
I wanted to note the fact that this string is copied verbatim to the file. I could leave off the \n and instead s/following message/following line/ in the paragraph above?
On 29 May 2015, at 17:18, Igor Galić notifications@github.com wrote:
In README.md #320 (comment):
@@ -183,9 +183,13 @@ Specifies whether to add a header message at the top of the destination file. Va
If you set 'warn' to 'true',concatadds the following message:-# This file is managed by Puppet. DO NOT EDIT. +# This file is managed by Puppet. DO NOT EDIT.\n not really sure how useful the \n here is in the README…—
Reply to this email directly or view it on GitHub https://github.com/puppetlabs/puppetlabs-concat/pull/320/files#r31339621.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 2.0.0, this parameter would add a newline at the end of the warn
message. To improve flexibilty, this was removed. Please add it
explicitely if you need it.