Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests for rspec-puppet 2.0 This patch changes `should` to `catalogue` for raise_error matchers since `should` has the same problems as `subject`, where it is not evaluated the way it used to be. We also unpin rspec-puppet. Guard validate_cmd test for older puppet versions Test group membership only on newer puppet The defined() function doesn't seem to work properly with puppet 3.4 and rspec. defined() works on its own, rspec works on its own, but together they determine that $gid is not defined and cause errors here. Work around it by ignoring this check for older puppet version.
|
|
underscorgan
pushed a commit
that referenced
this pull request
Jun 12, 2015
(╯°□°)╯︵┻━┻ the 2.0.x rewrite
|
A more descriptive message would be helpful indeed. I'm just seeing this PR as my R10K deployment started failing a few minutes ago 😉 |
|
sorry @lollipopman @bennycornelissen, should've checked that before merging. @bmjen will add more in the comments here at least. |
mwhahaha
pushed a commit
to mwhahaha/puppetlabs-concat
that referenced
this pull request
Jul 19, 2015
This change addresses MODULES-2115 and is a backport of the fixes that were included as part of puppetlabs#340.
mwhahaha
pushed a commit
to mwhahaha/puppetlabs-concat
that referenced
this pull request
Jul 20, 2015
This change addresses MODULES-2115 and is a backport of the fixes that were included as part of puppetlabs#340.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts concat master back to 1.2.x.
If you aren’t using puppetlabs-concat or are still using the puppetlabs-concat module with version 1.x you don’t need to continue reading. But, if you’re using puppetlabs-concat 2.0.x...
tl;dr - we have uncovered an issue in the Puppet core that impacts the puppetlabs-concat 2.0.x series and are deleting those releases from the forge. Please downgrade your environments to use puppetlabs-concat 1.2.x.
We recently reworked the puppetlabs-concat module to transition from an exec running a ruby script to concatenate files together to a native type (hooray!). This gave us vast performance improvements, but with the way the type was implemented we ended up running into a Puppet bug (https://tickets.puppetlabs.com/browse/PUP-1963)
that we can’t effectively work around with the existing code. Due to this, we’re pulling the 2.0.x release series. The Puppet bug was causing us to not properly propagate notify and subscribe metaparameters triggered by changes in puppetlabs-concat resources. This means that, for example, services subscribing to concat resources will not get restarted when the configuration file is updated.
To mitigate these issues, the puppetlabs-concat 2.0.x releases will be deleted from the forge. They will still be available for download but will not be installable using the PMT. We are still hoping to rework puppetlabs-concat to use a native type, however we don’t have a firm timeline for when that work will happen.
https://groups.google.com/forum/#!topic/puppet-dev/4_Sxrfl4uUY