Fix line endings on windows #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2015
bwwhite
pushed a commit
to bwwhite/puppetlabs-concat
that referenced
this pull request
Nov 18, 2015
In puppetlabs/pull/373 the .gitattributes file was updated so that all .rb files should have LF line endings. quoted_paths_spec.rb had CRLF endings, so upon checkout it would be marked as changed.
bwwhite
added a commit
to bwwhite/puppetlabs-concat
that referenced
this pull request
Nov 18, 2015
In puppetlabs/pull/373 the .gitattributes file was updated so that all .rb files should have LF line endings. quoted_paths_spec.rb had CRLF endings, but was not converted with that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7eb14b7 removed files/concatfragments.sh and used concatfragments.rb instead. #80 fixed the issue i have for the former .sh file, this PR fixes it for the new .rb file.
actually, this changes the line endings for all .rb files. i don't know whether that's the right way to go...