added (file) $replace parameter to concat #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, looks good - can you please update the comment block to show it as an option? If you can I think this would be a good thing to test in the tests as well. |
|
Description added, I never did anything with the tests before, will dive later into this (will try this week) when I have a little bit more time. And will add it also to the tests. Thanks! |
|
OK will merge this one - if you can do some tests that'd be awesome, please do a new pull then. |
ripienaar
added a commit
that referenced
this pull request
Dec 12, 2012
added (file) $replace parameter to concat
|
Check, looks interesting those tests, so will look into it ASAP! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi R.I. I have added the file replace parameter to the concat module, I have a situation where I need this. Would be nice if you would like to merge this upstream.