Fix the minimum required stdlib version to 4.2.0. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppetlabs@f4241b5 referenced is_bool() from stdlib that was only added in 4.2.0, according to: https://github.com/puppetlabs/puppetlabs-stdlib/blob/04fa5a0cd9255dc2d51af517be7164db9ea0306b/CHANGELOG.md
parabolala
pushed a commit
to parabolala/puppet-netatalk
that referenced
this pull request
Jan 31, 2016
Latest concat (as of 2.1.0 puppetlabs/puppetlabs-concat@f4241b5) doesn't have concat::setup. It (concat) also requires at least stdlib 4.2.0 (though this is not reflected in its deps ATM due to bug described in puppetlabs/puppetlabs-concat#386). Relax the stdlib dep restriction as well.
|
@bmjen can you have a look at this ? It makes sense the change, but i wonder about backwards compatibility already being broken. |
parabolala
pushed a commit
to parabolala/puppet-netatalk
that referenced
this pull request
Feb 6, 2016
Latest concat (as of 2.1.0 puppetlabs/puppetlabs-concat@f4241b5) doesn't have concat::setup. It (concat) also requires at least stdlib 4.2.0 (though this is not reflected in its deps ATM due to bug described in puppetlabs/puppetlabs-concat#386). Relax the stdlib dep restriction as well.
tphoney
added a commit
that referenced
this pull request
Feb 18, 2016
Fix the minimum required stdlib version to 4.2.0.
|
Thanks for the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f4241b5 referenced is_bool() from stdlib that was only added in 4.2.0, according to: https://github.com/puppetlabs/puppetlabs-stdlib/blob/04fa5a0cd9255dc2d51af517be7164db9ea0306b/CHANGELOG.md