(MODULES-3332 ) Correct the path validation. #397
Conversation
Prior to this commit, the validation would check for a `Concat_file` with the same **title** as the fragment's **path**. Unfortunately, they're not guaranteed to be the same. The `path` defaults to the `title` but can be passed in by the user.
binford2k
changed the title
|
I should also say that, this is an unusual use of |
|
I concur with the odd unusual usage, unless that was intention. I do the same sort of thing but actually utilize the autorequire. https://github.com/sfu-rcg/puppet-firewalld/blob/master/lib/puppet/type/firewalld_rich_rule.rb#L125-L129 |
|
Yep, it's specifically because |
|
@binford2k It appears that this change causes an existing test to fail: https://github.com/puppetlabs/puppetlabs-concat/blob/master/spec/acceptance/warnings_spec.rb#L45 |
Prior to this, the acceptance test was testing for a warning and only succeeding incidentally. It failed, not because the path was incorrect, but because the concat_file resource was named 'file' and not the full path.
|
@binford2k Sorry, could you also update the readme as well? The |
|
The check looks specifically to fix the case See #400 for a possible fix |
Prior to this commit, the validation would check for a
Concat_filewith the same title as the fragment's path. Unfortunately, they're not guaranteed to be the same. Thepathdefaults to thetitlebut can be passed in by the user.